Skip to content

Commit

Permalink
Refactor sash hover border to use CSS var
Browse files Browse the repository at this point in the history
  • Loading branch information
rzhao271 committed Nov 4, 2022
1 parent 6621cfa commit 79bcdd5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
5 changes: 5 additions & 0 deletions src/vs/base/browser/ui/sash/sash.css
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@
background: transparent;
}

.monaco-sash.hover:before,
.monaco-sash.active:before {
background: var(--vscode-sash-hoverBorder);
}

.monaco-sash.vertical:before {
width: var(--sash-hover-size);
left: calc(50% - (var(--sash-hover-size) / 2));
Expand Down
12 changes: 0 additions & 12 deletions src/vs/workbench/contrib/sash/browser/sash.contribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import { Registry } from 'vs/platform/registry/common/platform';
import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration';
import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from 'vs/workbench/common/contributions';
import { SashSettingsController } from 'vs/workbench/contrib/sash/browser/sash';
import { registerThemingParticipant } from 'vs/platform/theme/common/themeService';
import { sashHoverBorder } from 'vs/platform/theme/common/colorRegistry';
import { isIOS } from 'vs/base/common/platform';

// Sash size contribution
Expand Down Expand Up @@ -39,13 +37,3 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
},
}
});

registerThemingParticipant((theme, collector) => {
const sashHoverBorderColor = theme.getColor(sashHoverBorder);
collector.addRule(`
.monaco-sash.hover:before,
.monaco-sash.active:before {
background: ${sashHoverBorderColor};
}
`);
});

0 comments on commit 79bcdd5

Please sign in to comment.