Revert "Fix layers overlap and cutting at edges. (#85724)"

This reverts commit 74ffa79.
microsoft · Dec 4, 2019 · 7f1975a · 7f1975a
1 parent a43fc5f
commit 7f1975a
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 22 deletions.
diff --git a/src/vs/workbench/browser/media/part.css b/src/vs/workbench/browser/media/part.css
@@ -5,26 +5,7 @@
 
 .monaco-workbench .part {
 	box-sizing:	border-box;
-}
-
-.monaco-workbench.windows.chromium .part,
-.monaco-workbench.linux.chromium .part {
-	/*
-	 * Explicitly put the part onto its own layer to help Chrome to
-	 * render the content with LCD-anti-aliasing. By partioning the
-	 * workbench into multiple layers, we can ensure that a bad
-	 * behaving part is not making another part fallback to greyscale
-	 * rendering.
-	 *
-	 * macOS: does not render LCD-anti-aliased.
-	 */
-	transform: translate3d(0px, 0px, 0px);
-	position: relative;
-}
-
-.monaco-workbench.windows.chromium .part:focus-within,
-.monaco-workbench.linux.chromium .part:focus-within {
-	z-index: 1000;
+	overflow: hidden;
 }
 
 .monaco-workbench .part > .title {

diff --git a/src/vs/workbench/browser/parts/activitybar/media/activitybarpart.css b/src/vs/workbench/browser/parts/activitybar/media/activitybarpart.css
@@ -7,6 +7,21 @@
 	width: 48px;
 }
 
+.monaco-workbench.windows.chromium .part.activitybar,
+.monaco-workbench.linux.chromium .part.activitybar {
+	/*
+	 * Explicitly put the part onto its own layer to help Chrome to
+	 * render the content with LCD-anti-aliasing. By partioning the
+	 * workbench into multiple layers, we can ensure that a bad
+	 * behaving part is not making another part fallback to greyscale
+	 * rendering.
+	 *
+	 * macOS: does not render LCD-anti-aliased.
+	 */
+	transform: translate3d(0px, 0px, 0px);
+	overflow: visible; /* when a new layer is created, we need to set overflow visible to avoid clipping the menubar */
+}
+
 .monaco-workbench .activitybar > .content {
 	height: 100%;
 	display: flex;

diff --git a/src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css b/src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css
@@ -17,7 +17,9 @@
 	transform: translate3d(0px, 0px, 0px);
 }
 
-
+.monaco-workbench .part.sidebar > .content {
+	overflow: hidden;
+}
 
 .monaco-workbench.nosidebar > .part.sidebar {
 	display: none !important;

diff --git a/src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css b/src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css
@@ -19,7 +19,21 @@
 	display: flex;
 }
 
-
+.monaco-workbench.windows .part.titlebar,
+.monaco-workbench.linux .part.titlebar {
+	/*
+	 * Explicitly put the part onto its own layer to help Chrome to
+	 * render the content with LCD-anti-aliasing. By partioning the
+	 * workbench into multiple layers, we can ensure that a bad
+	 * behaving part is not making another part fallback to greyscale
+	 * rendering.
+	 *
+	 * macOS: does not render LCD-anti-aliased.
+	 */
+	transform: translate3d(0px, 0px, 0px);
+	position: relative;
+	z-index: 1000; /* move the entire titlebar above the workbench, except modals/dialogs */
+}
 
 .monaco-workbench .part.titlebar > .titlebar-drag-region {
 	top: 0;