Merge pull request #229966 from microsoft/tyriar/229872

Prevent terminal SI decorations showing under quick fixes
microsoft · Sep 27, 2024 · 8af8a57 · 8af8a57
2 parents 38b087c + 73f3a3e
commit 8af8a57
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts b/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts
@@ -247,7 +247,7 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon,
  if (!marker) {
  return;
  }
- const decoration = this._terminal.registerDecoration({ marker, layer: 'top' });
+ const decoration = this._terminal.registerDecoration({ marker, width: 2, layer: 'top' });
  if (!decoration) {
  return;
  }
@@ -284,7 +284,7 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon,
  updateLayout(this._configurationService, e);
  this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalQuickFix);
 
- const parentElement = (e.closest('.xterm') as HTMLElement).parentElement;
+ const parentElement = e.closest('.xterm')?.parentElement;
  if (!parentElement) {
  return;
  }