Try to prevent update of user-type Windows installation when running …

…as admin (#148428) (#155631)

* Try to prevent update of user-type Windows installation when running as admin (#148428)

* update win32: detect admin mode in initialize

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

src/vs/code/electron-main/app.ts

@@ -1181,7 +1181,7 @@ export class CodeApplication extends Disposable {
 		// Initialize update service
 		const updateService = accessor.get(IUpdateService);
 		if (updateService instanceof Win32UpdateService || updateService instanceof LinuxUpdateService || updateService instanceof DarwinUpdateService) {
-			updateService.initialize();
+			await updateService.initialize();
 		}
 
 		// Start to fetch shell environment (if needed) after window has opened

src/vs/platform/update/electron-main/abstractUpdateService.ts

@@ -59,7 +59,7 @@ export abstract class AbstractUpdateService implements IUpdateService {
 	 * optimization, to avoid using extra CPU cycles before first window open.
 	 * https://github.com/microsoft/vscode/issues/89784
 	 */
-	initialize(): void {
+	async initialize(): Promise<void> {
 		if (!this.environmentMainService.isBuilt) {
 			return; // updates are never enabled when running out of sources
 		}

src/vs/platform/update/electron-main/updateService.darwin.ts

@@ -38,8 +38,8 @@ export class DarwinUpdateService extends AbstractUpdateService {
 		super(lifecycleMainService, configurationService, environmentMainService, requestService, logService, productService);
 	}
 
-	override initialize(): void {
-		super.initialize();
+	override async initialize(): Promise<void> {
+		await super.initialize();
 		this.onRawError(this.onError, this, this.disposables);
 		this.onRawUpdateAvailable(this.onUpdateAvailable, this, this.disposables);
 		this.onRawUpdateDownloaded(this.onUpdateDownloaded, this, this.disposables);

src/vs/platform/update/electron-main/updateService.win32.ts

@@ -71,6 +71,15 @@ export class Win32UpdateService extends AbstractUpdateService {
 		super(lifecycleMainService, configurationService, environmentMainService, requestService, logService, productService);
 	}
 
+	override async initialize(): Promise<void> {
+		if (this.productService.target === 'user' && await this.nativeHostMainService.isAdmin(undefined)) {
+			this.logService.info('update#ctor - updates are disabled due to running as Admin in user setup');
+			return;
+		}
+
+		super.initialize();
+	}
+
 	protected buildUpdateFeedUrl(quality: string): string | undefined {
 		let platform = 'win32';