Fixes #173495

microsoft · Apr 21, 2023 · 8d20762 · 8d20762
1 parent b2cddf3
commit 8d20762
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/vs/editor/contrib/inlineCompletions/browser/utils.ts b/src/vs/editor/contrib/inlineCompletions/browser/utils.ts
@@ -71,18 +71,14 @@ export class ColumnRange {
 
 export function applyObservableDecorations(editor: ICodeEditor, decorations: IObservable<IModelDeltaDecoration[]>): IDisposable {
 	const d = new DisposableStore();
-	let decorationIds: string[] = [];
+	const decorationsCollection = editor.createDecorationsCollection();
 	d.add(autorun(`Apply decorations from ${decorations.debugName}`, reader => {
 		const d = decorations.read(reader);
-		editor.changeDecorations(a => {
-			decorationIds = a.deltaDecorations(decorationIds, d);
-		});
+		decorationsCollection.set(d);
 	}));
 	d.add({
 		dispose: () => {
-			editor.changeDecorations(a => {
-				decorationIds = a.deltaDecorations(decorationIds, []);
-			});
+			decorationsCollection.clear();
 		}
 	});
 	return d;