Fix #163383

microsoft · Apr 26, 2023 · 9b265dc · 9b265dc
1 parent 2d34614
commit 9b265dc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/vs/workbench/api/common/extHostConfiguration.ts b/src/vs/workbench/api/common/extHostConfiguration.ts
@@ -236,6 +236,9 @@ export class ExtHostConfigProvider {
  }
  });
  }
+ if (Array.isArray(target)) {
+ return deepClone(target);
+ }
  return target;
  };
  result = cloneOnWriteProxy(result, key);

diff --git a/src/vs/workbench/api/test/browser/extHostConfiguration.test.ts b/src/vs/workbench/api/test/browser/extHostConfiguration.test.ts
@@ -771,6 +771,16 @@ suite('ExtHostConfiguration', function () {
  testObject.$acceptConfigurationChanged(newConfigData, configEventData);
  });
 
+ test('get return instance of array value', function () {
+ const testObject = createExtHostConfiguration({ 'far': { 'boo': [] } });
+
+ const value: string[] = testObject.getConfiguration().get('far.boo', []);
+ value.push('a');
+
+ const actual = testObject.getConfiguration().get('far.boo', []);
+ assert.deepStrictEqual(actual, []);
+ });
+
  function aWorkspaceFolder(uri: URI, index: number, name: string = ''): IWorkspaceFolder {
  return new WorkspaceFolder({ uri, name, index });
  }