Make experimental and clamp numbers

microsoft · Nov 5, 2024 · a05a955 · a05a955
1 parent b211f03
commit a05a955
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/vs/workbench/browser/workbench.contribution.ts b/src/vs/workbench/browser/workbench.contribution.ts
@@ -490,14 +490,14 @@ const registry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Con
 				'description': localize('workbench.quickOpen.preserveInput', "Controls whether the last typed input to Quick Open should be restored when opening it the next time."),
 				'default': false
 			},
-			'workbench.quickOpen.maximumWidth': {
+			'workbench.quickOpen.experimental.maximumWidth': {
 				'type': 'number',
 				'description': localize('workbench.quickOpen.maxWidth', "Limits the maximum width of Quick Open to the specified number of pixels."),
 				'default': 600,
 				'minimum': 200,
 				'maximum': 2000
 			},
-			'workbench.quickOpen.relativeWidth': {
+			'workbench.quickOpen.experimental.relativeWidth': {
 				'type': 'number',
 				'description': localize('workbench.quickOpen.relativeWidth', "Controls the width of Quick Open relative to the total window width."),
 				'default': 0.62,

diff --git a/src/vs/workbench/services/quickinput/browser/quickInputService.ts b/src/vs/workbench/services/quickinput/browser/quickInputService.ts
@@ -14,6 +14,7 @@ import { QuickInputService as BaseQuickInputService } from '../../../../platform
 import { InstantiationType, registerSingleton } from '../../../../platform/instantiation/common/extensions.js';
 import { IQuickInputService } from '../../../../platform/quickinput/common/quickInput.js';
 import { InQuickPickContextKey } from '../../../browser/quickaccess.js';
+import { clamp } from '../../../../base/common/numbers.js';
 
 export class QuickInputService extends BaseQuickInputService {
 
@@ -40,8 +41,8 @@ export class QuickInputService extends BaseQuickInputService {
 	protected override createController(): QuickInputController {
 		return super.createController(this.layoutService, {
 			ignoreFocusOut: () => !this.configurationService.getValue('workbench.quickOpen.closeOnFocusLost'),
-			maximumWidth: () => this.configurationService.getValue('workbench.quickOpen.maximumWidth'),
-			relativeWidth: () => this.configurationService.getValue('workbench.quickOpen.relativeWidth'),
+			maximumWidth: () => clamp(this.configurationService.getValue('workbench.quickOpen.experimental.maximumWidth'), 200, 2000),
+			relativeWidth: () => clamp(this.configurationService.getValue('workbench.quickOpen.experimental.relativeWidth'), 0.5, 0.9),
 			backKeybindingLabel: () => this.keybindingService.lookupKeybinding('workbench.action.quickInputBack')?.getLabel() || undefined,
 		});
 	}