Implement password (#48116)

microsoft · Apr 23, 2018 · a8633b2 · a8633b2
1 parent 8768250
commit a8633b2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/vs/workbench/browser/parts/quickinput/quickInput.ts b/src/vs/workbench/browser/parts/quickinput/quickInput.ts
@@ -39,7 +39,6 @@ type InputParameters = SelectManyParameters | TextInputParameters;
 
 export interface BaseInputParameters {
  readonly type: 'selectMany' | 'textInput';
- readonly placeHolder?: string;
  readonly ignoreFocusLost?: boolean;
 }
 
@@ -48,13 +47,16 @@ export interface SelectManyParameters<T extends IPickOpenEntry = IPickOpenEntry>
  readonly picks: TPromise<T[]>;
  readonly matchOnDescription?: boolean;
  readonly matchOnDetail?: boolean;
+ readonly placeHolder?: string;
 }
 
 export interface TextInputParameters extends BaseInputParameters {
  readonly type: 'textInput';
  readonly value?: string;
  readonly valueSelection?: [number, number];
  readonly prompt?: string;
+ readonly placeHolder?: string;
+ readonly password?: boolean;
  readonly validateInput?: (input: string) => TPromise<string>;
 }
 
@@ -132,6 +134,7 @@ class TextInputController implements InputController<string> {
  ? localize('inputModeEntryDescription', "{0} (Press 'Enter' to confirm or 'Escape' to cancel)", parameters.prompt)
  : localize('inputModeEntry', "Press 'Enter' to confirm your input or 'Escape' to cancel");
  ui.message.textContent = defaultMessage;
+ ui.inputBox.setPassword(parameters.password);
 
  if (parameters.validateInput) {
  const onDidChange = debounceEvent(ui.inputBox.onDidChange, (last, cur) => cur, 100);
@@ -380,6 +383,7 @@ export class QuickInputService extends Component implements IQuickInputService {
  valueSelection: options.valueSelection,
  prompt: options.prompt,
  placeHolder: options.placeHolder,
+ password: options.password,
  ignoreFocusLost: options.ignoreFocusLost,
  validateInput: options.validateInput,
  }, token);

diff --git a/src/vs/workbench/browser/parts/quickinput/quickInputBox.ts b/src/vs/workbench/browser/parts/quickinput/quickInputBox.ts
@@ -66,6 +66,10 @@ export class QuickInputBox {
  this.inputBox.setPlaceHolder(placeholder);
  }
 
+ setPassword(isPassword: boolean): void {
+ this.inputBox.inputElement.type = isPassword ? 'password' : 'text';
+ }
+
  setFocus(): void {
  this.inputBox.focus();
  }