Ensure terminal rows and cols are always >= 1

Fixes #35117
microsoft · Sep 27, 2017 · ace4220 · ace4220
1 parent 0c90b53
commit ace4220
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts b/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts
@@ -214,7 +214,7 @@ export class TerminalInstance implements ITerminalInstance {
 		const scaledSpaceAvailable = dimension.height * window.devicePixelRatio;
 		const scaledCharHeight = Math.ceil(font.charHeight * window.devicePixelRatio);
 		const scaledLineHeight = Math.floor(scaledCharHeight * font.lineHeight);
-		this._rows = Math.floor(scaledSpaceAvailable / scaledLineHeight);
+		this._rows = Math.max(Math.floor(scaledSpaceAvailable / scaledLineHeight), 1);
 
 		return dimension.width;
 	}

diff --git a/src/vs/workbench/parts/terminal/node/terminalProcess.ts b/src/vs/workbench/parts/terminal/node/terminalProcess.ts
@@ -90,7 +90,9 @@ process.on('message', function (message) {
 	if (message.event === 'input') {
 		ptyProcess.write(message.data);
 	} else if (message.event === 'resize') {
-		ptyProcess.resize(message.cols, message.rows);
+		// Ensure that cols and rows are always >= 1, this prevents a native
+		// exception in winpty.
+		ptyProcess.resize(Math.max(message.cols, 1), Math.max(message.rows, 1));
 	} else if (message.event === 'shutdown') {
 		queueProcessExit();
 	}