fix: remove emulation check and notification on windows (#186008)

microsoft · Jun 26, 2023 · b4952d1 · b4952d1
1 parent 352e7da
commit b4952d1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/src/vs/code/electron-main/app.ts b/src/vs/code/electron-main/app.ts
@@ -1279,7 +1279,7 @@ export class CodeApplication extends Disposable {
 		// Crash reporter
 		this.updateCrashReporterEnablement();
 
-		if (app.runningUnderARM64Translation) {
+		if (isMacintosh && app.runningUnderARM64Translation) {
 			this.windowsMainService?.sendToFocused('vscode:showTranslatedBuildWarning');
 		}
 

diff --git a/src/vs/platform/native/electron-main/nativeHostMainService.ts b/src/vs/platform/native/electron-main/nativeHostMainService.ts
@@ -490,7 +490,7 @@ export class NativeHostMainService extends Disposable implements INativeHostMain
 	}
 
 	async isRunningUnderARM64Translation(): Promise<boolean> {
-		if (isLinux) {
+		if (isLinux || isWindows) {
 			return false;
 		}
 		return app.runningUnderARM64Translation;

diff --git a/src/vs/workbench/electron-sandbox/window.ts b/src/vs/workbench/electron-sandbox/window.ts
@@ -236,15 +236,8 @@ export class NativeWindow extends Disposable {
 					label: localize('downloadArmBuild', "Download"),
 					run: () => {
 						const quality = this.productService.quality;
-						let stableURL = '';
-						let insidersURL = '';
-						if (isMacintosh) {
-							stableURL = 'https://code.visualstudio.com/docs/?dv=osx';
-							insidersURL = 'https://code.visualstudio.com/docs/?dv=osx&build=insiders';
-						} else if (isWindows) {
-							stableURL = 'https://code.visualstudio.com/docs/?dv=win32arm64user';
-							insidersURL = 'https://code.visualstudio.com/docs/?dv=win32arm64user&build=insiders';
-						}
+						const stableURL = 'https://code.visualstudio.com/docs/?dv=osx';
+						const insidersURL = 'https://code.visualstudio.com/docs/?dv=osx&build=insiders';
 						this.openerService.open(quality === 'stable' ? stableURL : insidersURL);
 					}
 				}]