Skip to content

Commit

Permalink
debug: fix stackFrame equality matching
Browse files Browse the repository at this point in the history
  • Loading branch information
isidorn committed May 5, 2020
1 parent e1869c5 commit bf77670
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/vs/workbench/contrib/debug/common/debugModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ export class StackFrame implements IStackFrame {
}

equals(other: IStackFrame): boolean {
return (this.name === other.name) && (other.thread === this.thread) && (other.source === this.source) && (Range.equalsRange(this.range, other.range));
return (this.name === other.name) && (other.thread === this.thread) && (this.frameId === other.frameId) && (other.source === this.source) && (Range.equalsRange(this.range, other.range));
}
}

Expand Down Expand Up @@ -957,6 +957,8 @@ export class DebugModel implements IDebugModel {
for (let i = 1; i < stale.length && !bottomOfCallStackChanged; i++) {
bottomOfCallStackChanged = !stale[i].equals(current[i]);
}
console.log('bottom of call stack changed');
console.log(bottomOfCallStackChanged);

if (bottomOfCallStackChanged) {
this._onDidChangeCallStack.fire();
Expand Down

0 comments on commit bf77670

Please sign in to comment.