Skip to content

Commit

Permalink
fix version references
Browse files Browse the repository at this point in the history
  • Loading branch information
joaomoreno committed Feb 19, 2016
1 parent 4761feb commit cd853bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export class InstallAction extends Action {
this.messageService.show(
Severity.Info,
{
message: nls.localize('success-installed', "{0} {1} was successfully installed. Restart to enable it.", extension.displayName, extension.version),
message: nls.localize('success-installed', "'{0}' was successfully installed. Restart to enable it.", extension.displayName),
actions: [this.instantiationService.createInstance(ReloadWindowAction, ReloadWindowAction.ID, nls.localize('restartNow', "Restart Now"))]
}
);
Expand Down Expand Up @@ -170,7 +170,7 @@ export class UninstallAction extends Action {
}

public run(extension: IExtension): TPromise<any> {
if (!window.confirm(nls.localize('deleteSure', "Are you sure you want to uninstall the '{0}' extension?", extension.displayName))) {
if (!window.confirm(nls.localize('deleteSure', "Are you sure you want to uninstall '{0}'?", extension.displayName))) {
return TPromise.as(null);
}

Expand All @@ -187,7 +187,7 @@ export class UninstallAction extends Action {
this.messageService.show(
Severity.Info,
{
message: nls.localize('success-uninstalled', "{0} was successfully uninstalled. Restart to deactivate it.", extension.displayName),
message: nls.localize('success-uninstalled', "'{0}' was successfully uninstalled. Restart to deactivate it.", extension.displayName),
actions: [this.instantiationService.createInstance(ReloadWindowAction, ReloadWindowAction.ID, nls.localize('restartNow2', "Restart Now"))]
}
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function createExtension(manifest: IExtensionManifest, galleryInformation?: IGal
}

function getExtensionId(extension: IExtensionManifest, version = extension.version): string {
return `${ extension.publisher }.${ extension.name }-${ extension.version }`;
return `${ extension.publisher }.${ extension.name }-${ version }`;
}

export class ExtensionsService implements IExtensionsService {
Expand Down

0 comments on commit cd853bb

Please sign in to comment.