Skip to content

Commit

Permalink
Only track first time installs for recommended extensions #49583
Browse files Browse the repository at this point in the history
  • Loading branch information
ramya-rao-a committed May 10, 2018
1 parent be4c738 commit d0182c3
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -799,18 +799,17 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService,
const extension: Extension = installingExtension ? installingExtension : zipPath ? new Extension(this.galleryService, this.stateProvider, null, null, this.telemetryService) : null;
if (extension) {
this.installing = installingExtension ? this.installing.filter(e => e !== installingExtension) : this.installing;

const installed = this.installed.filter(e => e.id === extension.id)[0];
if (!error) {
extension.local = local;
const installed = this.installed.filter(e => e.id === extension.id)[0];
if (installed) {
installed.local = local;
} else {
this.installed.push(extension);
}
}
if (extension.gallery) {
// Report telemetry only for gallery extensions
if (extension.gallery && !installed) {
// Report recommendation telemetry only for gallery extensions that are first time installs
this.reportExtensionRecommendationsTelemetry(installingExtension);
}
}
Expand Down

0 comments on commit d0182c3

Please sign in to comment.