Feedback from resolveTreeItem API proposal review

Part of #100741
microsoft · Nov 23, 2020 · ea989da · ea989da
1 parent 21a4224
commit ea989da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -1028,7 +1028,7 @@ declare module 'vscode' {
  * @param element
  * @param item Undefined properties of `item` should be set then `item` should be returned.
  */
- resolveTreeItem?(element: T, item: TreeItem2): TreeItem2 | Thenable<TreeItem2>;
+ resolveTreeItem?(item: TreeItem2, element: T): ProviderResult<TreeItem2>;
  }
 
  export class TreeItem2 extends TreeItem {

diff --git a/src/vs/workbench/api/common/extHostTreeViews.ts b/src/vs/workbench/api/common/extHostTreeViews.ts
@@ -379,7 +379,7 @@ class ExtHostTreeView<T> extends Disposable {
  if (element) {
  const node = this.nodes.get(element);
  if (node) {
- const resolve = await this.dataProvider.resolveTreeItem(element, node.extensionItem);
+ const resolve = await this.dataProvider.resolveTreeItem(node.extensionItem, element) ?? node.extensionItem;
  // Resolvable elements. Currently only tooltip.
  node.item.tooltip = this.getTooltip(resolve.tooltip);
  return node.item;