use textContent instead of innerHTML (for #106285)

microsoft · Sep 9, 2020 · f0dd2d2 · f0dd2d2
1 parent 420aa32
commit f0dd2d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/vs/base/browser/ui/codicons/codiconStyles.ts b/src/vs/base/browser/ui/codicons/codiconStyles.ts
@@ -20,7 +20,7 @@ function initialize() {
 		for (let c of iconRegistry.all) {
 			rules.push(formatRule(c));
 		}
-		codiconStyleSheet.innerHTML = rules.join('\n');
+		codiconStyleSheet.textContent = rules.join('\n');
 	}
 
 	const delayer = new RunOnceScheduler(updateAll, 0);

diff --git a/src/vs/workbench/services/themes/browser/workbenchThemeService.ts b/src/vs/workbench/services/themes/browser/workbenchThemeService.ts
@@ -685,10 +685,10 @@ function _applyRules(styleSheetContent: string, rulesClassName: string) {
 		const elStyle = document.createElement('style');
 		elStyle.type = 'text/css';
 		elStyle.className = rulesClassName;
-		elStyle.innerHTML = styleSheetContent;
+		elStyle.textContent = styleSheetContent;
 		document.head.appendChild(elStyle);
 	} else {
-		(<HTMLStyleElement>themeStyles[0]).innerHTML = styleSheetContent;
+		(<HTMLStyleElement>themeStyles[0]).textContent = styleSheetContent;
 	}
 }