defaults web issue report false and disable in Firefox (#213752)

* turn off in release and in ff * update
microsoft · May 29, 2024 · fc8762e · fc8762e
1 parent bc9e1b8
commit fc8762e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/vs/workbench/contrib/issue/browser/issue.contribution.ts b/src/vs/workbench/contrib/issue/browser/issue.contribution.ts
@@ -40,7 +40,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
 		properties: {
 			'issueReporter.experimental.webReporter': {
 				type: 'boolean',
-				default: true,
+				default: false,
 				description: 'Enable experimental issue reporter for web.',
 			},
 		}

diff --git a/src/vs/workbench/contrib/issue/browser/issueService.ts b/src/vs/workbench/contrib/issue/browser/issueService.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as dom from 'vs/base/browser/dom';
-import { userAgent } from 'vs/base/common/platform';
+import { isFirefox, userAgent } from 'vs/base/common/platform';
 import { IExtensionDescription, ExtensionType } from 'vs/platform/extensions/common/extensions';
 import { normalizeGitHubUrl } from 'vs/platform/issue/common/issueReporterUtil';
 import { getZoomLevel } from 'vs/base/browser/browser';
@@ -49,7 +49,8 @@ export class BrowserIssueService implements IWorkbenchIssueService {
 	}
 
 	async openReporter(options: Partial<IssueReporterData>): Promise<void> {
-		if (!this.configurationService.getValue<boolean>('issueReporter.experimental.webReporter')) {
+		// If web reporter setting is false, or if we are in Firefox, open the old GitHub issue reporter
+		if (!this.configurationService.getValue<boolean>('issueReporter.experimental.webReporter') || isFirefox) {
 			const extensionId = options.extensionId;
 			// If we don't have a extensionId, treat this as a Core issue
 			if (!extensionId) {