Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporter cannot send data directly to GitHub #100054

Closed
peterkos opened this issue Jun 13, 2020 · 6 comments
Closed

Error reporter cannot send data directly to GitHub #100054

peterkos opened this issue Jun 13, 2020 · 6 comments
Assignees

Comments

@peterkos
Copy link

peterkos commented Jun 13, 2020

  • VSCode Version: 1.46.0
  • OS Version: macOS 10.15.4

Attempting to send any somewhat-detailed bug report gives this error:

There is too much data to send to GitHub directly. The data will be copied to the clipboard, please paste it into the GitHub issue page that is opened.

I tried to send the following message:

  1. Search for an extension (e.g., "Custom CSS and JS Loader")
  2. Attempt to copy the config information to put in settings.json via Cmd+C
  3. Notice that it doesn't work (Cmd+V does not yield those contents)
  4. Select that text and use Edit>Copy (in menu bar) to copy
  5. Notice that your clipboard now has those contents

Two main concerns here.

First, this is around 319 bytes of UTF-8 for "Steps to Reproduce". Is this a GitHub API limitation of some sort? This is very strange and I've never seen an application do this.

Second, I think this is really bad UX:

  • The "Steps to Reproduce" area takes up a large portion of the screen, of which I've filled not even half.
    Screen Shot 2020-06-13 at 12 55 56 AM
  • The "include system information" and "include my enabled extensions" both still remain checked, which is not indicative of the current state (clipboard only contains "steps to reproduce")
  • The "opened for you" GitHub issue does not include any issue template information in the clipboard (VSCode version, OS version).
  • The user, after filling out two select fields, two text fields, and two check boxes, must redo that work on GitHub.
@peterkos
Copy link
Author

I see in this issue (#73921) that it is performance-related, however I don't think this adresses the UX issues that are present (issue template info, system info, etc.)

Apologies if this is too close to that issue!

@peterkos
Copy link
Author

And also, here is the list of extensions I have:

Screen Shot 2020-06-13 at 1 08 00 AM

@RMacfarlane
Copy link
Contributor

Hey @peterkos, here's an explanation of why dialog appears: #97171 (comment) The limit is based on number of characters, not bytes, and is unfortunately pretty easy to hit with just system info/extensions.

I'm not seeing what you describe with that information not being copied when you click "OK" in the dialog - all of the diagnostic information should be copied to the clipboard at that time. What version of VS Code are you using?

@peterkos
Copy link
Author

Thanks for the info! That makes a bit more sense. I'm using VSCode version 1.46.0; also updated my original post.

Also I think that was my fault; I tried again (a few times to make sure) and it does indeed copy all info. I must have copied the steps to reproduce myself, overwriting the clipboard 😅

@RMacfarlane
Copy link
Contributor

I'm going to go ahead and close this, since the copy to clipboard functionality is working

@peterkos
Copy link
Author

This still seems like a usability issue to force the user to copy&paste, even though I understand the technical limitation there.

(For anyone browsing, to save some digging, see #95165 for discussion on bypassing the limitation.)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants