Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt GitHub Auth provider for issues reporter #95165

Closed
RMacfarlane opened this issue Apr 14, 2020 · 3 comments
Closed

Adopt GitHub Auth provider for issues reporter #95165

RMacfarlane opened this issue Apr 14, 2020 · 3 comments
Assignees
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues on-testplan
Milestone

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Apr 14, 2020

Since we now have a way for users to login to GitHub within VSCode, we can leverage this in the issue reporter. As a first step, if the user is already signed in and we have a token with scopes for creating an issue, we can just directly post the issue instead of showing the intermediate "new issue" page

@RMacfarlane RMacfarlane added feature-request Request for new features or functionality authentication Issues with the Authentication platform labels Apr 14, 2020
@RMacfarlane RMacfarlane added this to the April 2020 milestone Apr 14, 2020
@RMacfarlane RMacfarlane self-assigned this Apr 14, 2020
@RMacfarlane RMacfarlane added the issue-reporter Issue reporter widget issues label Apr 14, 2020
@RMacfarlane RMacfarlane modified the milestones: April 2020, Backlog Apr 24, 2020
@wolf99
Copy link

wolf99 commented May 16, 2020

Point to note: users may have one set of credentials that they work against, but may want to report issues under a different set of credentials. (e.g. work vs personal).

@peterkos
Copy link

peterkos commented Sep 17, 2020

Could the UI promote this solution so the (imo hacky) copy&paste is avoided?
The issue report screen could be broken into two workflows (if not connected):

  • "Connect with GitHub to report an issue" button (opens form after signin, works without copy&paste)
  • "Open GitHub in your browser" (opens issue template directly in GitHub, avoids form entirely)

And if connected, it would just show the form directly.

@peterkos
Copy link

Any updates on this?

@RMacfarlane RMacfarlane modified the milestones: Backlog, January 2021 Jan 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues on-testplan
Projects
None yet
Development

No branches or pull requests

4 participants
@wolf99 @peterkos @RMacfarlane and others