Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript broken hightlights #100638

Closed
rpidburachynskyi opened this issue Jun 20, 2020 · 3 comments
Closed

Typescript broken hightlights #100638

rpidburachynskyi opened this issue Jun 20, 2020 · 3 comments
Assignees
@mjbvz
Labels
*duplicate Issue identified as a duplicate of another issue(s) grammar Syntax highlighting grammar typescript Typescript support issues

Comments

@rpidburachynskyi
Copy link

rpidburachynskyi commented Jun 20, 2020 •
edited
Loading

Bug with typescript hightlights when use new line in templates, types is not hightlights green color

Single line
image

Multiline
image

  • VSCode Version: 1.46.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Copy and paste to *.ts file
@IllusionMH
Copy link
Contributor

Duplicate of other issues that has microsoft/TypeScript-TmLanguage#479 as root cause.

This kind of problem is handled by "editor.semanticHighlighting.enabled": true. Do you have it enabled?
image

Example without semantic highlight
image

@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) grammar Syntax highlighting grammar typescript Typescript support issues labels Jun 23, 2020
@rpidburachynskyi
Copy link
Author

rpidburachynskyi commented Jun 23, 2020 •
edited
Loading

Duplicate of other issues that has microsoft/TypeScript-TmLanguage#479 as root cause.

This kind of problem is handled by "editor.semanticHighlighting.enabled": true. Do you have it enabled?
image

Example without semantic highlight
image

Hello, sorry for late reply. Yes, I've enabled this option, it work only for hard (custom) types, but not work for number/boolean/string etc

image

@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*duplicate Issue identified as a duplicate of another issue(s) grammar Syntax highlighting grammar typescript Typescript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@IllusionMH @mjbvz @rpidburachynskyi and others