Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic type parameters do not highlight when multiline #479

Closed
AlexanderOtavka opened this issue Jun 26, 2017 · 6 comments
Closed

Generic type parameters do not highlight when multiline #479

AlexanderOtavka opened this issue Jun 26, 2017 · 6 comments
Labels
limitation Issue is result of tmLanguage limitation where in the lookup does not go beyond current line wontfix Issue is either side effect or limitation that will not be fixed for now

Comments

@AlexanderOtavka
Copy link

TS and JS Grammar Extension version: 0.0.22 / latest

Code

const withConnect = connect<
  StateProps,
  DispatchProps,
  Props
>((state: StateModel) => ({
  list: state.rides.list,
}))

In vscode, we get the following highlighting:

screen shot 2017-06-26 at 12 08 32 pm

It drops the yellow of the function name, as well as the teal of the type params that we would expect when it is all on one line.

Expected highlight colors

screen shot 2017-06-26 at 12 15 32 pm

@AlexanderOtavka
Copy link
Author

Whoops, looks like this is a duplicate of #475

@AlexanderOtavka
Copy link
Author

Actually, after reading the full comment chain of #475, I'm reopening this since my code is actually valid.

@sheetalkamat
Copy link
Member

As mentioned in #475 (comment) this is by design.

@sheetalkamat sheetalkamat added the wontfix Issue is either side effect or limitation that will not be fixed for now label Jun 26, 2017
@AlexanderOtavka
Copy link
Author

Ok, that comment chain was a bit confusing. Are there future plans to fix the grammar so it works over multiple lines? It's kind of annoying having syntax highlighting break for multiline expressions.

@sheetalkamat
Copy link
Member

It cant be fixed to lookup over multiple lines as that's the limitation of tmLanguage syntax.

@AlexanderOtavka
Copy link
Author

Gotcha. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
limitation Issue is result of tmLanguage limitation where in the lookup does not go beyond current line wontfix Issue is either side effect or limitation that will not be fixed for now
Projects
None yet
Development

No branches or pull requests

2 participants