Notebooks: have a lot of unneeded margins/paddings?

[bpasero]

Testing #100965

I find this could be more condense.

[miguelsolorio]

This was intentional, previously code cells and markdown cells were on the same vertical plane and it was hard to tell which cells were code vs markdown (especially when edited a markdown cell). So we decided to indent code cells to give better hierarchy.

We could tighten the left margin by a few pixels (~8px) but we'd still need to keep the code cells indented.

[roblourens]

@bpasero are you thinking about horizontal padding or vertical padding or both?

[bpasero]

Both horizontal and vertical padding! Maybe have a setting where I can decide if I want the condense view or not.

Now that I look at my screenshot from #101366 (comment) again, it really feels like there is a bug in notebook that prevents some data to be shown.

[miguelsolorio]

I've updated the overall padding/margin around the cells, between the cells, and inside the editors:

I also created #101635 to propose to hide the status bar until needed, and #101633 to explore a more compact bottom toolbar which will reduce more space.

Let me know if this looks good for you and we can close out this issue.

[bpasero]

It is better, thanks for reducing it. I still think there is lots of whitespace, e.g. here:

The line around Config: defines the inbox query being in small font having almost 5x the line height as surrounding whitespace.

[bpasero]

@rebornix @misolori is there any way I can see how this used to look in 1.46? How can I run an older notebook UX currently, if possible?

[roblourens]

You can see it in stable, starting with --enable-proposed-api for whichever extension

[bpasero]

@roblourens this results in:

Unable to open 'inbox.github-issues': Cannot read property 'backupId' of undefined.

[roblourens]

Oh, I guess you would have to use an older build of the extension. It works for the markdown notebook.

[bpasero]

Thanks that works 👍

[rebornix]

The editor inner left padding issue is extracted to #101808 .

[miguelsolorio]

I think we've addressed a lot of these issues, below is a comparison from June => July:

Let us know if you think it's better.

[isidorn]

I see there are improvments, adding verified and Ben can open more issues once he is back if this did not capture everything he pointed out.