compacted debug sessions should show name of child and not of parent

[weinand]

Testing #101009

When hierarchical debug sessions are compacted, the resulting tree node uses the name of the parent session, not the name of the child session.

So this uncompressed tree:

becomes this:

IMO this does not make sense because the compact feature eliminates the parent when there is only one child.
It does not eliminate the child.

[isidorn]

@weinand what you are saying makes sense, however for js-debug this would not really work that well scine the child sessions have "weird names".

What I suggest: we change this on the vscode side as you suggest - to use the child name
And @connor4312 improves on the JS-debug side the names of child sessions: for example to be NAME_OF_CONFIG + process ID
So something like "Launch Program 1452"

[weinand]

@isidorn yes, we we will have to go with your proposal.

Another argument for that approach: with the current behavior the "weird name" child gets the "nice name" from the parent. But if another child arrives, suddenly two "weird names" shows up...

---

An alternative approach would be that VS Code automatically concatenates the names from parent and child as you suggested. But I'm not sure how well that would work in practice...

@connor4312 what's your take on this?

[int19h]

It's not just JS. Python also has "weird" child session names - they're basically "Subprocess ...", where ... is the process ID. Concatenating them would also not work well.

I'm not sure why it's a weird scheme, though. This naming scheme works just fine when the tree is fully expanded - it tells users exactly what they need to know, without overburdening them with redundant information that's already available (e.g. repeating parent process name). It feels weird having to change that just to play well with a subset of scenarios that involve compacting.

Also, if #101140 is implemented, I don't think it would be accurate to describe compacting as eliminating the parent session anymore.

[isidorn]

After discussions with @weinand we decided to do the following changes:

• Change the noCompact flag to be compact flag and thus the default value is to not compact sessions. So this is opt-in
• Changed call stack to display the name of the Child Session. I actually think by default it does not looks so "weird"

@connor4312 As a follow up for js-debug I have created this item microsoft/vscode-js-debug#551
@int19h as a follow up for python I have created microsoft/vscode-python-debugger#166