Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Authentication providers - consumer API #103871

Closed
4 tasks done
RMacfarlane opened this issue Aug 3, 2020 · 2 comments
Closed
4 tasks done

Test: Authentication providers - consumer API #103871

RMacfarlane opened this issue Aug 3, 2020 · 2 comments
Labels
testplan-item
Milestone
July 2020

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Aug 3, 2020 •
edited by 9at8
Loading

Refs: #100993

Complexity: 4

Create Issue

In this iteration, part of the authentication API has been moved to stable, allowing extensions to consume GitHub and Microsoft authentication.

Please test that

  • The API itself is clear, comments are readable and contain enough information, and names make sense.
  • getSession behaves as expected with different options passed into it.
  • Calling getSession causes the authentication provider to activate if it has not done so already; there shouldn't be any issues with accessing a session immediately on startup.
  • onDidChangeSessions is fired on login and logout
@RMacfarlane RMacfarlane added this to the July 2020 milestone Aug 3, 2020
This was referenced Aug 4, 2020
Closed
Closed
Open
@eamodio eamodio removed their assignment Aug 4, 2020
@eamodio
Copy link
Contributor

eamodio commented Aug 4, 2020

Great work!

This was referenced Aug 5, 2020
Closed
Closed
Closed
Closed
@sandy081 sandy081 removed their assignment Aug 5, 2020
@sandy081
Copy link
Member

sandy081 commented Aug 5, 2020

Works great 👏

@9at8 9at8 mentioned this issue Aug 5, 2020
Merged
@bamurtaugh bamurtaugh mentioned this issue Aug 5, 2020
Merged
@bamurtaugh bamurtaugh removed their assignment Aug 5, 2020
@9at8 9at8 removed their assignment Aug 5, 2020
@rebornix rebornix closed this as completed Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
6 participants
@eamodio @rebornix @RMacfarlane @9at8 @sandy081 @bamurtaugh