Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convenient to pass no options instead of empty options #104078

Closed
sandy081 opened this issue Aug 5, 2020 · 0 comments
Closed

Convenient to pass no options instead of empty options #104078

sandy081 opened this issue Aug 5, 2020 · 0 comments
Assignees
@RMacfarlane
Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2020

Comments

@sandy081
Copy link
Member

sandy081 commented Aug 5, 2020

Testing #103871

Instead of passing empty options

const session = await vscode.authentication.getSession(GITHUB_AUTH_PROVIDER_ID, SCOPES, {});

it is convenient to pass no options

const session = await vscode.authentication.getSession(GITHUB_AUTH_PROVIDER_ID, SCOPES);
@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug authentication Issues with the Authentication platform labels Aug 5, 2020
@RMacfarlane RMacfarlane added this to the July 2020 milestone Aug 5, 2020
@sandy081 sandy081 added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@RMacfarlane @sandy081 and others