Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hovers to show at cursor's x position instead of the left of the target element #104058

Closed
Tyriar opened this issue Aug 5, 2020 · 5 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-hover Hover issues in the workbench
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 5, 2020

Current:

89308368-78d40c80-d672-11ea-8248-6ed0d0cb0b2f

Desired:

image

Context: #100741

@Tyriar Tyriar added polish Cleanup and polish issue workbench-hover Hover issues in the workbench labels Aug 5, 2020
@Tyriar Tyriar added this to the July 2020 milestone Aug 5, 2020
@Tyriar Tyriar self-assigned this Aug 5, 2020
@Tyriar Tyriar modified the milestones: July 2020, August 2020 Aug 5, 2020
@eamodio
Copy link
Contributor

eamodio commented Aug 11, 2020

I would also say it should be "pop" down, rather than up (unless there is no room) -- like normal tooltips. Although much less of an issue than the x position.

@eamodio
Copy link
Contributor

eamodio commented Aug 12, 2020

Related issue: If a hover is too wide for the tree, it seems to cause it to move down and ends up covering the row its for

Here the view is wide enough and its fine

image

But here its too narrow, and you can't see the item for which the hover is for

image

@Tyriar
Copy link
Member Author

Tyriar commented Aug 12, 2020

I would also say it should be "pop" down, rather than up (unless there is no room) -- like normal tooltips. Although much less of an issue than the x position.

It aligns with hovers in the editor now, I'd rather not make things inconsistent without a compelling reason.

But here its too narrow, and you can't see the item for which the hover is for

Looks like a bug, please create another issue

@Tyriar
Copy link
Member Author

Tyriar commented Aug 12, 2020

@alexr00 there's now an x?: number on the target for this, let me know if there are issues 🙂

@alexr00
Copy link
Member

alexr00 commented Aug 13, 2020

Works nicely, thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-hover Hover issues in the workbench
Projects
None yet
Development

No branches or pull requests

4 participants
@eamodio @Tyriar @alexr00 and others