Allow hover x to be overridden

Fixes #104058
microsoft · Aug 12, 2020 · 115d7cf · 115d7cf
1 parent 0b03a79
commit 115d7cf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/vs/workbench/services/hover/browser/hover.ts b/src/vs/workbench/services/hover/browser/hover.ts
@@ -109,4 +109,10 @@ export interface IHoverTarget extends IDisposable {
  * wrapped text.
  */
  readonly targetElements: readonly HTMLElement[];
+
+ /**
+ * An optional absolute x coordinate to position the hover with, for example to position the
+ * hover using `MouseEvent.pageX`.
+ */
+ x?: number;
 }
diff --git a/src/vs/workbench/services/hover/browser/hoverWidget.ts b/src/vs/workbench/services/hover/browser/hoverWidget.ts
@@ -136,9 +136,10 @@ export class HoverWidget extends Widget {
  this._hover.containerDomNode.classList.remove('right-aligned');
  this._hover.contentsDomNode.style.maxHeight = '';
 
- // Get horizontal alignment and position
  const targetBounds = this._target.targetElements.map(e => e.getBoundingClientRect());
- const targetLeft = Math.min(...targetBounds.map(e => e.left));
+
+ // Get horizontal alignment and position
+ let targetLeft = this._target.x !== undefined ? this._target.x : Math.min(...targetBounds.map(e => e.left));
  if (targetLeft + this._hover.containerDomNode.clientWidth >= document.documentElement.clientWidth) {
  this._x = document.documentElement.clientWidth;
  this._hover.containerDomNode.classList.add('right-aligned');