Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] Two extra colons added when completing a pseudo-selector #104111

Closed
Dean-NC opened this issue Aug 5, 2020 · 3 comments · Fixed by gizlang/gizcode-extension-samples#95 · 4 remaining pull requests
Closed

[css] Two extra colons added when completing a pseudo-selector #104111

Dean-NC opened this issue Aug 5, 2020 · 3 comments · Fixed by gizlang/gizcode-extension-samples#95 · 4 remaining pull requests
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling info-needed Issue requires more information from poster
Milestone

Comments

@Dean-NC
Copy link

Dean-NC commented Aug 5, 2020

  • VSCode Version: 1.47.3
  • OS Version: Windows x64 10.0.18363

Steps to Reproduce:

  1. Similar steps as with issue Two colons added when completing pseudo-selector in nested scss #30176. For CSS in <style> tag in .html (haven't tested .css file), type any selector, example: div, then type 2 colons. Intellisense may/may not show ::before as a hilighted suggestion. If it does, press the tab or enter key, and you'll end-up with 4 colons.

  2. If intellisense does not show ::before as a higlighted suggestion, type "be", so that you have "div::be" typed so far. Intellisense should be showing ::before as a highlited suggestion. Press the tab or enter key, and you'll end-up with 4 colons.

Untitled

It seems the coders only tested typing a single colon when testing intellisense and auto-completion.

Does this issue occur when all extensions are disabled?: Yes

@aeschli
Copy link
Contributor

aeschli commented Aug 12, 2020

Sorry, you have to provide more detailed steps, I'm not able to reproduce.

Peek 2020-08-12 15-52

@aeschli aeschli added html HTML support issues info-needed Issue requires more information from poster labels Aug 12, 2020
@Dean-NC
Copy link
Author

Dean-NC commented Aug 13, 2020

@aeschli Here's 2 of the same demo files (small, stripped-down), 1 that works correctly and 1 that doesn't. The cause seems to be a combination of the preceding style rule and the following comment and style rule.

Demo files.zip

ExtraColons

@aeschli aeschli added this to the Backlog Candidates milestone Nov 5, 2020
@aeschli aeschli added css-less-scss Issues and items concerning CSS,Less,SCSS styling and removed html HTML support issues labels Nov 5, 2020
@aeschli aeschli changed the title Two extra colons added when pressing tab or enter, when completing a CSS pseudo-selector [css] Two extra colons added when completing a pseudo-selector Nov 5, 2020
aeschli added a commit to microsoft/vscode-css-languageservice that referenced this issue Nov 5, 2020
aeschli added a commit to microsoft/vscode-css-languageservice that referenced this issue Nov 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.