Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Types compatibility: renderCodicons – return HTMLElement instead of string #105588

Closed
annkamsk opened this issue Aug 28, 2020 · 0 comments · Fixed by #105589
Closed

Trusted Types compatibility: renderCodicons – return HTMLElement instead of string #105588

annkamsk opened this issue Aug 28, 2020 · 0 comments · Fixed by #105589
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
August 2020

Comments

@annkamsk
Copy link
Contributor

The next step in resolving #103699. renderCodicons function returns a string possibly containing lots of tags, which is usually assigned then to .innerHTML property of some parent element. The goal is to create an additional version of renderCodicons that uses HTMLElements.
@annkamsk annkamsk mentioned this issue Aug 28, 2020
Merged
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Aug 31, 2020
@jrieken jrieken added this to the August 2020 milestone Aug 31, 2020
jrieken added a commit that referenced this issue Sep 1, 2020
@jrieken
mark renderCodicons as deprecated, #105588
7d3489c
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
August 2020
Development

Successfully merging a pull request may close this issue.

Make renderCodicons function return HTMLElement instead of string annkamsk/vscode
3 participants
@jrieken @annkamsk and others