Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite progress when webview view provider is not registered #105834

Closed
sandy081 opened this issue Sep 1, 2020 · 3 comments
Closed

Infinite progress when webview view provider is not registered #105834

sandy081 opened this issue Sep 1, 2020 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug *out-of-scope Posted issue is not in scope of VS Code webview Webview issues
Milestone
On Deck

Comments

@sandy081
Copy link
Member

sandy081 commented Sep 1, 2020

Testing #105764

  • Register a webview view in package.json
  • Do not register webview view provider
  • Open the webview and there is an infinite progress
  • It is expected to show an error at some point of time
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 1, 2020

How long do you give tree views to resolve?

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues labels Sep 1, 2020
@mjbvz mjbvz added this to the Backlog milestone Sep 1, 2020
@sandy081
Copy link
Member Author

sandy081 commented Sep 2, 2020

2 seconds

https://github.com/microsoft/vscode/blob/908559b/src/vs/workbench/contrib/views/browser/treeView.ts#L1034

@mjbvz mjbvz modified the milestones: Backlog, On Deck Sep 28, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 4, 2021

Closing this due to lack of additional feedback. Happy to take a PR though if anyone is feeling ambitious and wants to explore fixing this

@mjbvz mjbvz closed this as completed Oct 4, 2021
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug *out-of-scope Posted issue is not in scope of VS Code webview Webview issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@sandy081 @mjbvz