Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test webview view api proposal #105764

Closed
3 tasks done
mjbvz opened this issue Aug 31, 2020 · 1 comment
Closed
3 tasks done

Test webview view api proposal #105764

mjbvz opened this issue Aug 31, 2020 · 1 comment

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 31, 2020

Refs #46585

Complexity: 5

Create Issue


Overview

The new webview view API allows extensions to contribute views build on webviews. For this exploratory test plan item, try using the new API and discovering what works and what doesn't. Areas to focus on:

  • Start with the webview view extension sample

  • Review the docs for the new apis in vscode.proposed.d.ts

  • Look at webview view lifecycle (and showing and hiding view)

    • Does the dispose lifecycle make sense?
    • Are events for show/hide fired when you expect?
  • Look at state management for the webview views

    • Make sure that webview state is persisted when: vscode is reloaded, a view is collapsed, a view is moved, a view is hidden.
    • Try using retainContextWhenHidden
@sandy081
Copy link
Member

sandy081 commented Sep 1, 2020

I used retainContextWhenHidden but did not understand what difference it is making in the example. It would be nice if there is a sample that demonstrates it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants