Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in WebviewViewResolveContext docs #105874

Closed
RMacfarlane opened this issue Sep 1, 2020 · 0 comments
Closed

Typo in WebviewViewResolveContext docs #105874

RMacfarlane opened this issue Sep 1, 2020 · 0 comments
Assignees
@mjbvz
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Milestone
August 2020

Comments

@RMacfarlane
Copy link
Contributor

Testing #105764

vscode/src/vs/vscode.proposed.d.ts

Line 2089 in df30a1f

* collapse a view or switching to another top level activity, the underlying webview document is deallocates.

should be:

collapses a view or is switching to another top level activity, the underlying webview document is deallocated
@mjbvz mjbvz added this to the August 2020 milestone Sep 1, 2020
@mjbvz mjbvz added api bug Issue identified by VS Code Team member as probable bug webview Webview issues labels Sep 1, 2020
@mjbvz mjbvz closed this as completed in bf7597e Sep 1, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
3 participants
@RMacfarlane @mjbvz and others