Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onDidDispose is fired when view is moved #107842

Open
sbatten opened this issue Sep 30, 2020 · 1 comment
Open

onDidDispose is fired when view is moved #107842

sbatten opened this issue Sep 30, 2020 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug webview Webview issues
Milestone
Backlog

Comments

@sbatten
Copy link
Member

sbatten commented Sep 30, 2020

Testing #105764

If this is expected, then it should be mentioned in the .d.ts as the documentation implies that the only case is hiding the view.
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 30, 2020

This is a bug. Specifically it happens when moving a view to a top level container and back or when moving a view between containers

@mjbvz mjbvz added this to the Backlog milestone Sep 30, 2020
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues labels Sep 30, 2020
This was referenced Sep 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug webview Webview issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sbatten @mjbvz