[WebviewView] Changing Title When webviewView.visible === false

[GordonSmith]

Testing #105764

When the WebviewView is not visible, changing the title is not reflected visually:

        this._webviewView.onDidChangeVisibility(e => {
            this._webviewView.title = this._webviewView.visible ? "All Good!": "Never Displayed";
        });

[mjbvz]

Doesn't reproduce for me:

Can you please share your full example?

[GordonSmith]

I should have mentioned that his is when its in a bottom "Panel" and not a side tree, IOW:

 "contributes": {
    "viewsContainers": {
      "panel": [
        {
          "id": "my-fancy-view",
          "title": "Fancy View",
          "icon": "fancy.icon"
        }
      ]
    },
    "views": {
      "my-fancy-view": [
        {
          "type": "webview",
          "id": "my-webview",
          "name": "Webview"
        }
      ]
    }
  }

[mjbvz]

@sbatten I believe the issue is in CompositePart here:

vscode/src/vs/workbench/browser/parts/compositePart.ts

Line 288 in 12fc18b

if (this.activeComposite && this.activeComposite.getId() === compositeId) {

If an extension updates the title when switching away from a view—or updates the title of a non-active view—then the if condition fails so we never call this.updateTitle.

Could we move the updateTitle call outside of the conditional?

[sbatten]

reverted 2ac1523, will fix with a separate implementation of update title like panelPart has