Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reset "visibility" property on webview view in package.json #105855

Closed
RMacfarlane opened this issue Sep 1, 2020 · 1 comment
Closed
Assignees

Comments

@RMacfarlane
Copy link
Contributor

Testing #105764

  1. Use the webview view extension sample: https://github.com/Microsoft/vscode-extension-samples/tree/master/webview-view-sample
  2. Modify the view contribution point to set "visibility" to "visible"
		"views": {
			"explorer": [
				{
					"type": "webview",
					"id": "calicoColors.colorsView",
					"name": "Calico Colors",
					"visibility": "visible"
				}
			]
		},
  1. Run extension and expand the explorer, view is visible as expected
  2. Change "visibility" to another value, or remove the property, and rerun the extension

The view seems to now be cached in an expanded state and the new "visibility" value is ignored

@RMacfarlane
Copy link
Contributor Author

Actually, I think this is working as expected - I think I collapsed and reopened the view, which would prevent the initial state from being picked up again.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants