Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Syntax Highlighting for New Logical Assignment Variables #106070

Closed
EchoApeiron opened this issue Sep 3, 2020 · 3 comments
Closed
Assignees
Labels
javascript JavaScript support issues upstream-issue-fixed The underlying upstream issue has been fixed

Comments

@EchoApeiron
Copy link

EchoApeiron commented Sep 3, 2020

  • VSCode Version: 1.48.2
  • OS Version: Windows 10, Build 19041

Steps to Reproduce:

  1. In a JavaScript code file try to assign a variable using one of the logical assignment variables:

u ||= prompt('Enter something...', 0);

Rather than this:

u = u || prompt('Enter something...', 0);

Reference to the following documentation:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators

Does this issue occur when all extensions are disabled?: No

@mjbvz mjbvz self-assigned this Sep 3, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 8, 2020

So this only happens when extensions are enabled? Which one causes the problem?

@mjbvz mjbvz added grammar Syntax highlighting grammar javascript JavaScript support issues info-needed Issue requires more information from poster labels Sep 8, 2020
@EchoApeiron
Copy link
Author

EchoApeiron commented Sep 8, 2020 via email

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 8, 2020

Duplicate of microsoft/TypeScript#37255

Seems to work in VS Code 1.49 (the current insiders builds)

Screen Shot 2020-09-08 at 3 19 45 PM

@mjbvz mjbvz closed this as completed Sep 8, 2020
@mjbvz mjbvz added upstream-issue-fixed The underlying upstream issue has been fixed and removed grammar Syntax highlighting grammar info-needed Issue requires more information from poster labels Sep 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues upstream-issue-fixed The underlying upstream issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants