Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Webiew View API finalization #107626

Closed
3 tasks done
mjbvz opened this issue Sep 28, 2020 · 1 comment
Closed
3 tasks done

Test Webiew View API finalization #107626

mjbvz opened this issue Sep 28, 2020 · 1 comment

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 28, 2020

Refs #46585

Complexity: 5

Create Issue

Create Issue


Overview

The webview view API has now been finalized. In this plan item, try going through to test the api and the experience of writing an extension for it

  • Start with the webview view extension sample

  • Review the docs for the new apis in vscode.d.ts

  • Look at webview view lifecycle (and showing and hiding view)

    • Does the dispose lifecycle make sense?
    • Are events for show/hide fired when you expect?
  • Look at state management for the webview views

    • Make sure that webview state is persisted when: vscode is reloaded, a view is collapsed, a view is moved, a view is hidden.
    • Try using retainContextWhenHidden. When this is enabled, then switching so that the webview is no longer visible should preserve the iframe context itself.
@roblourens
Copy link
Member

Are there going to be some docs about this on the website?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants