Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webview view's urls to contain the extension id like normal webviews #107820

Closed
eamodio opened this issue Sep 30, 2020 · 7 comments
Closed
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Sep 30, 2020

Testing #107626

I was using the following in my launch.json:

"debugWebviews": true,
"rendererDebugOptions": {
	"urlFilter": "*eamodio.gitlens*",
	"webRoot": "${workspaceFolder}/src/webviews/apps"
},

And was unable to get js-debug to debug my new webview view (although normal webviews worked fine). @connor4312 pointed out the urlFilter and when I removed that everything worked.

Looking at the urls attached, you can see the difference between a normal webview and the webview view:

image

We should probably add the extension id into the webview view's url, so that we can consistently only attach to the webviews we want.

@eamodio eamodio added the webview Webview issues label Sep 30, 2020
@connor4312
Copy link
Member

Thanks, I was just about to open this issue 🙂

@connor4312
Copy link
Member

I hacked it in in the linked commit; not very familiar with this part of the code. Let me know if you think it's worth PRing @mjbvz

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Nov 3, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 7, 2021

Closing since I think this work is done now? Let me know if that's not the case @connor4312

@connor4312
Copy link
Member

I don't think so -- I pushed a tentative commit to a branch but didn't merge it

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 7, 2021

Ah sorry, I missed that the commit wasn't in main. Want to create a PR @connor4312?

@mjbvz mjbvz closed this as completed in 011b20c Oct 14, 2021
@mjbvz mjbvz added this to the October 2021 milestone Oct 14, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 14, 2021

Cherrypicked the commit in. I think the url now has the id as expected (tested with docs view):

Screen Shot 2021-10-14 at 4 39 17 PM

But let me know if this doesn't work for the debugger for some reason

@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Oct 26, 2021
@JacksonKearl JacksonKearl added the verified Verification succeeded label Oct 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests

5 participants
@eamodio @connor4312 @JacksonKearl @mjbvz and others