Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-file: Extension development locations are blocked #107690

Closed
sandy081 opened this issue Sep 29, 2020 · 3 comments
Closed

vscode-file: Extension development locations are blocked #107690

sandy081 opened this issue Sep 29, 2020 · 3 comments
Assignees
Labels
debt Code quality issues sandbox Running VSCode in a node-free environment
Milestone

Comments

@sandy081
Copy link
Member

Testing #107466

Platform: Windows

  • Debugging the tree view sample extension of our extension samples
  • In the debugging window, the package explorer icon is not shown

Here is the css it is using

-webkit-mask: url(vscode-file://vscode-app/c:/Work/vscode-extension-samples/tree-view-sample/media/dep.svg) 50% 50% / 24px no-repeat;

image

It works correctly when I used normal build

@bpasero bpasero added this to the October 2020 milestone Sep 29, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug sandbox Running VSCode in a node-free environment labels Sep 29, 2020
@bpasero bpasero changed the title Viewlet container icon is not displayed vscode-file: Extension development locations are blocked Oct 1, 2020
@bpasero
Copy link
Member

bpasero commented Oct 1, 2020

Interesting, the issue is that we do not know about the extension development location here:

const validRoots = coalesce([
URI.file(environmentService.appRoot),
environmentService.extensionsPath ? URI.file(environmentService.extensionsPath) : undefined,
...environmentService.extensionDevelopmentLocationURI ?? []
]);

Because the location is only present when the second window opens. We will have to find a way to dynamically update the allowed locations based on opened windows.

//cc @deepak1556

@sandy081
Copy link
Member Author

sandy081 commented Dec 3, 2020

@bpasero Is there a build I can use to verify this?

@sandy081 sandy081 added the verification-steps-needed Steps to verify are needed for verification label Dec 3, 2020
@bpasero
Copy link
Member

bpasero commented Dec 3, 2020

No, I think this is fine to not verify as we dont ship this.

@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug verification-steps-needed Steps to verify are needed for verification labels Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues sandbox Running VSCode in a node-free environment
Projects
None yet
Development

No branches or pull requests

2 participants