Debug hover is show on top of the item I wanted the hover for

[sandy081]

Testing #107156

• I am debugging the tree view sample extension in our extension samples and when I hovered on following rootPath value in vscode.workspace.rootPath, the debug hover is shown covering the item completely

[isidorn]

The debug hover currently sets the preference to be placed above the location here. It is up to the editor to choose the exact location, and in this particular case the editor decided to show the hover covering the item completely.

I am not sure if we can do anything regarding this.

fyi @alexdima for potential ideas

[alexdima]

@isidorn Maybe there is a missing layoutContentWidget call after changing the inside of the debug hover?

The positioning code will measure the widget and then cache its height. It looks like the editor positions the widget as if it would be only one line height high (i.e. without the wrapping seen in the picture)

[isidorn]

@alexdima good idea, but that does not seem to be the case looking at the code.
I always first set the content of the widget, and only then call the layoutContentWidget
However the widget word wraps, and in this particualr case it looks like the css breaks the widget in two lines. So I am not aware how many lines the widget will be, it is all handled by css.

[alexdima]

@isidorn How about this code path --

vscode/src/vs/workbench/contrib/debug/browser/debugHover.ts

Line 142 in 5ab1d92

this.toDispose.push(this.tree.onDidChangeContentHeight(() => this.layoutTreeAndContainer(false)));

.. Shouldn't layoutContentWidget be called if there is a chance that the tree has expanded its height?

[isidorn]

@alexdima You are correct.
I have pushed a change to tackle that code path. However I do not expect this to fix @sandy081 case since in his case the debug hover is not a tree, but a simple value (which is a different code path).
Though might fix it... @sandy081 let me know if you no longer see this

[sandy081]

Is this in today's insiders?

[isidorn]

@sandy081 no, will be tomorrow. I just pushed 1 hour ago :)

[isidorn]

Closing as I pushed an improvment for this and no further actoin is planned