Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the help text/tip in the bottom of debug hover to switch to normal hover #107697

Closed
sandy081 opened this issue Sep 29, 2020 · 4 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #107156

Show the help text/tip in the bottom of debug hover to switch to normal hover

@isidorn
Copy link
Contributor

isidorn commented Sep 29, 2020

This is a good idea.
For now opening this to PRs. If nobody is interested I can tackle this in the future
Code pointer

export class DebugHoverWidget implements IContentWidget {

If there is somebody interested please first ping us here so we can also involve some design @misolori

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Sep 29, 2020
@isidorn isidorn added this to the On Deck milestone Sep 29, 2020
@isidorn isidorn added the help wanted Issues identified as good community contribution opportunities label Sep 29, 2020
@sseelam2
Copy link

sseelam2 commented Oct 1, 2020

@isidorn Hi Isidor, I am interested!

@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2020

@sseelam2 ok, great. So the things to note is that the debug hover has 2 modes.

  • First one is when a simple value is shown, for example when the user hovers over a string
  • Second one when an object is shown, for example when the user hovers over console in javascript. This mode contains a tree which can be expanded

It seems like we would have to introduce a common HTMLElement that will be used in both these cases.
This element would be placed after both the complex-value and the .value container.
Thing to note: layout of the other containers and the total height of the debug hover does not get broken.

Please note that there is no 100% chance that we accept this. I am still not sure who will this look in the end.

@misolori for potentially sketching something up if you find time.

@isidorn
Copy link
Contributor

isidorn commented Nov 13, 2020

Went ahead with this. This is how it looks like
I decided to only show the tip when hovering over a complex object with children. So this will not show when you hover over a simple string for example.

Screenshot 2020-11-13 at 10 01 39

@isidorn isidorn added the verification-needed Verification of issue is requested label Nov 13, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@isidorn @Tyriar @RMacfarlane @sandy081 @sseelam2 @ornelladotcom and others