Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TreeItem#command to be resolved in resolveTreeItem #110498

Closed
alexr00 opened this issue Nov 12, 2020 · 1 comment
Closed

Allow TreeItem#command to be resolved in resolveTreeItem #110498

alexr00 opened this issue Nov 12, 2020 · 1 comment
Assignees
@alexr00
Labels
api api-finalization api-proposal feature-request Request for new features or functionality tree-views Extension tree view issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2021

Comments

@alexr00
Copy link
Member

alexr00 commented Nov 12, 2020

This enables extensions to do any computing that is needed to have the correct command lazily. This is especially useful for extensions that make a command that calls a built in command. With this feature, the extension can set command to the built in command without having to register an additional command.

ref: #110497

Depends on #100741
@alexr00 alexr00 added feature-request Request for new features or functionality api tree-views Extension tree view issues api-proposal labels Nov 12, 2020
@alexr00 alexr00 added this to the Backlog milestone Nov 12, 2020
@alexr00 alexr00 self-assigned this Nov 12, 2020
This was referenced Nov 12, 2020
Closed
Closed
@alexr00 alexr00 modified the milestones: Backlog, January 2021 Dec 29, 2020
alexr00 added a commit that referenced this issue Dec 29, 2020
@alexr00
Allow tree item command to be resolved later
5dbfe32 
Part of #110498
@alexr00 alexr00 closed this as completed Jan 12, 2021
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Jan 18, 2021
@alexr00
Copy link
Member Author

alexr00 commented Jan 18, 2021

@eamodio you might be interested in verifying this one.

@connor4312 connor4312 added the verified Verification succeeded label Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
api api-finalization api-proposal feature-request Request for new features or functionality tree-views Extension tree view issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
2 participants
@connor4312 @alexr00