Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.api.getRemoteSources doesn't wait for providers to activate #111658

Closed
RMacfarlane opened this issue Dec 1, 2020 · 1 comment
Closed

git.api.getRemoteSources doesn't wait for providers to activate #111658

RMacfarlane opened this issue Dec 1, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues github Github extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Testing #111518

To get the GitHub picker to show up, I had to explicitly wait for the github extension to activate:

	const githubExtension = await vscode.extensions.getExtension('vscode.github');
	if (githubExtension) {
		await githubExtension.activate();
	}

	const results = await vscode.commands.executeCommand('git.api.getRemoteSources', {
		providerLabel: (provider: RemoteSourceProvider) => `Testing the branch picker of ${provider.name}`,
		urlLabel: `URL`,
		branch: true
	});

It would be cool if running 'git.api.getRemoteSources' triggered an activation event that extensions providing these sources could use.

@joaomoreno
Copy link
Member

Yeah this is a long standing issue with this approach, but one which we don't really have an answer for, unfortunately.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues github Github extension labels Dec 2, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Dec 2, 2020
@lszomoru lszomoru self-assigned this Oct 4, 2021
@joaomoreno joaomoreno modified the milestones: Backlog, November 2021 Nov 9, 2021
@alexr00 alexr00 added the verified Verification succeeded label Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues github Github extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @lszomoru @RMacfarlane @alexr00 and others