Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providerLabel not used with git.api.getRemoteSources #138407

Closed
alexr00 opened this issue Dec 3, 2021 · 2 comments
Closed

providerLabel not used with git.api.getRemoteSources #138407

alexr00 opened this issue Dec 3, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Dec 3, 2021

I was verifying #111658, when I saw that my providerLabel is not being used now.

Snippet:

    const results = await vscode.commands.executeCommand('git.api.getRemoteSources', {
        providerLabel: (provider: any) => `Testing the branch picker of ${provider.name}`,
        urlLabel: `URL`,
        branch: true
	});

In stable:
image

In insiders:
image

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jan 4, 2022
@lszomoru lszomoru added this to the January 2022 milestone Jan 4, 2022
@lszomoru
Copy link
Member

@alexr00, is this still an issue. Cannot reproduce this issue in the latest Insiders release.

image

@alexr00
Copy link
Member Author

alexr00 commented Jan 27, 2022

I also cannot repro anymore.

@alexr00 alexr00 added the verified Verification succeeded label Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants