Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug launch progress does not stop when launching using integrated terminal #11206

Closed
sandy081 opened this issue Aug 30, 2016 · 4 comments
Closed

Debug launch progress does not stop when launching using integrated terminal #11206

sandy081 opened this issue Aug 30, 2016 · 4 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
August 2016

Comments

@sandy081
Copy link
Member

sandy081 commented Aug 30, 2016 •
edited
Loading

Testing #11091

OS: OSX

Steps to Reproduce:

  1. Clone VS Code Smoke Test application
  2. Create a Node debug launch to run the application
  3. Use integratedTerminal as console in the launch
  4. Start the launch

Expected: Progress should stop
Observed: Progress keeps running as if launching is in progress

aug-30-2016 15-00-10
@sandy081 sandy081 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 30, 2016
@weinand
Copy link
Contributor

weinand commented Aug 30, 2016

@sandy081 and you do not see this behaviour if using the two other console options?

@sandy081
Copy link
Member Author

@weinand Yes, I see this behavior only with integrated terminal option

@weinand weinand added this to the August 2016 milestone Aug 30, 2016
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2016
@weinand weinand added the verification-needed Verification of issue is requested label Aug 31, 2016
weinand added a commit that referenced this issue Aug 31, 2016
@weinand
node-debug: fix for #11206
954e737
@rebornix rebornix added verified Verification succeeded and removed verified Verification succeeded labels Aug 31, 2016
@rebornix
Copy link
Member

@weinand I suppose the fix can only be verified with our next release of Insider, right?

@weinand
Copy link
Contributor

weinand commented Aug 31, 2016

@rebornix yes, correct.

@sandy081 sandy081 added the verified Verification succeeded label Sep 1, 2016
@weinand weinand removed the verification-needed Verification of issue is requested label Sep 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
3 participants
@rebornix @weinand @sandy081