Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discoverability of cell folding #113248

Closed
kieferrm opened this issue Dec 21, 2020 · 5 comments
Closed

Improve discoverability of cell folding #113248

kieferrm opened this issue Dec 21, 2020 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

We provide actions for folding cells. This is hard to discover. Jupyter supports double clicking on the focus bar which is rather intuitive. We don't have a focus bar, but we should explore whether we can find another way to support double click to fold/unfold cells.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Dec 21, 2020

I wonder if we could get away with double-clicking the empty space on the side. We do this double-click in other areas (explorer, suggest widget, find widget):

collapse-cells.mov

cc @rebornix @roblourens

@rebornix rebornix self-assigned this Feb 18, 2021
@roblourens roblourens self-assigned this Feb 18, 2021
roblourens added a commit that referenced this issue Mar 23, 2021
@roblourens
Copy link
Member

Implemented this, only works for code cells currently and only on the left side of the sidebar, needs #119535

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Mar 24, 2021
@miguelsolorio
Copy link
Contributor

@roblourens I'm not able to get this to work, do you have a screen recording?

@roblourens
Copy link
Member

I forgot to merge the notebook/dev branch with this change. It's not in the build yet...

@roblourens roblourens reopened this Mar 24, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@roblourens @rebornix @kieferrm @rzhao271 @miguelsolorio and others