Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook icon click feedback should be centered #115087

Closed
Tyriar opened this issue Jan 26, 2021 · 4 comments
Closed

Notebook icon click feedback should be centered #115087

Tyriar opened this issue Jan 26, 2021 · 4 comments
Assignees
@rebornix @miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
January 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2021

Testing #114969

This applies to the play button too

Actual:

image

Expected:

image
@miguelsolorio
Copy link
Contributor

@Tyriar is this in a diff view or regular notebook cell? hard to tell, assuming this is the play button and output renderer?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 28, 2021

@misolori regular notebook cell

@miguelsolorio
Copy link
Contributor

These are now centered

image

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug notebook labels Jan 29, 2021
@miguelsolorio miguelsolorio added this to the January 2021 milestone Jan 29, 2021
@rebornix rebornix added the verified Verification succeeded label Jan 29, 2021
plainerman pushed a commit to plainerman/vscode that referenced this issue Feb 2, 2021
@plainerman
Center notebook actions (run, stop, renderer, collapse, etc.) fixes m…
062c131 
…icrosoft#115087
MarcoZehe pushed a commit to MarcoZehe/vscode that referenced this issue Feb 3, 2021
@MarcoZehe
Center notebook actions (run, stop, renderer, collapse, etc.) fixes m…
0283640 
…icrosoft#115087
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
4 participants
@rebornix @Tyriar @miguelsolorio and others