Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't know what [1] means in notebooks #115095

Closed
Tyriar opened this issue Jan 26, 2021 · 8 comments · Fixed by #134416
Closed

I don't know what [1] means in notebooks #115095

Tyriar opened this issue Jan 26, 2021 · 8 comments · Fixed by #134416
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2021

Testing #114969

Unfiltered notebook noob feedback:

image

I was expecting a tooltip to tell me what it meant.

@rebornix rebornix added notebook bug Issue identified by VS Code Team member as probable bug labels Jan 28, 2021
@rebornix
Copy link
Member

Agreed that we should add tooltip for it.

@roblourens
Copy link
Member

roblourens commented Jan 28, 2021

@Tyriar how would you interpret it if there was a tooltip that said "Execution Order"?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 28, 2021

@roblourens when you run all cells it goes in that order? I was expecting that to be sequential from the top?

@roblourens
Copy link
Member

It's the order that it was executed it, not the order it will execute in. Hopefully a user would figure that out if they run the cell and see it change.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 28, 2021

@roblourens oh, more explicit would be better then imo

The order this cell was executed in

I also question why this is useful but I'm guessing this is a common notebooks feature elsewhere?

@roblourens
Copy link
Member

Yeah it's what people expect from Jupyter and can help you understand the state of the kernel

@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Aug 5, 2021
@rebornix rebornix added this to the Backlog milestone Aug 5, 2021
tanhakabir added a commit to tanhakabir/vscode that referenced this issue Oct 5, 2021
tanhakabir added a commit that referenced this issue Oct 5, 2021
@roblourens
Copy link
Member

roblourens commented Oct 11, 2021

Thanks @tanhakabir, that needs to be localized though. btw if you are going to merge your change in, you can just commit directly, no PR needed

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@roblourens @rebornix @Tyriar and others