-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cap size of the getting started images #115325
Comments
We could prevent scaling images over their natural height? cc @digitarald would that work for you? |
Yeah I think we should do that, but that alone wouldn't fix above due to the huge size of the image. Also consider how HDPI screenshots show up on standard dpi monitors |
These are 800x600 and exported with 1.5 dpi, so 1200x900. The images should not scale beyond 800px width, but there will be some blur for hdpi screens if we don't export with 2 dpi. I agree though that the max image size can be scaled down a bit in the design. |
Now scaling all images to 66% under assumption they're exported at 1.5x (max-width is still 800px). This means smaller images can be used where needed and they wont grow past their proper width. |
Change was to allow smaller images but hasn't been adopted yet. cc @digitarald we can use a smaller image there and it should work fine so long as we still have it at 1.5x scale. |
The image itself is very large and probably shouldn't be. If we do this the core may need a change to not stretch the image.
The text was updated successfully, but these errors were encountered: