Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap size of the getting started images #115325

Closed
Tyriar opened this issue Jan 28, 2021 · 7 comments
Closed

Cap size of the getting started images #115325

Tyriar opened this issue Jan 28, 2021 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2021

The image itself is very large and probably shouldn't be. If we do this the core may need a change to not stretch the image.

image

@JacksonKearl JacksonKearl added getting-started feature-request Request for new features or functionality labels Jan 28, 2021
@JacksonKearl JacksonKearl added this to the Backlog milestone Jan 28, 2021
@JacksonKearl
Copy link
Contributor

We could prevent scaling images over their natural height? cc @digitarald would that work for you?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 28, 2021

Yeah I think we should do that, but that alone wouldn't fix above due to the huge size of the image. Also consider how HDPI screenshots show up on standard dpi monitors

@JacksonKearl JacksonKearl modified the milestones: Backlog, February 2021 Jan 28, 2021
@digitarald
Copy link
Contributor

We could prevent scaling images over their natural height?

These are 800x600 and exported with 1.5 dpi, so 1200x900. The images should not scale beyond 800px width, but there will be some blur for hdpi screens if we don't export with 2 dpi.

I agree though that the max image size can be scaled down a bit in the design.

@JacksonKearl
Copy link
Contributor

Now scaling all images to 66% under assumption they're exported at 1.5x (max-width is still 800px). This means smaller images can be used where needed and they wont grow past their proper width.

JacksonKearl pushed a commit that referenced this issue Feb 4, 2021
@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Feb 23, 2021
@bpasero
Copy link
Member

bpasero commented Feb 24, 2021

I am still seeing a very large image:

image

@bpasero bpasero reopened this Feb 24, 2021
@bpasero bpasero added the verification-found Issue verification failed label Feb 24, 2021
@JacksonKearl
Copy link
Contributor

Change was to allow smaller images but hasn't been adopted yet. cc @digitarald we can use a smaller image there and it should work fine so long as we still have it at 1.5x scale.

@JacksonKearl JacksonKearl removed the verification-found Issue verification failed label Feb 24, 2021
@connor4312
Copy link
Member

Images now seem modestly sized

@connor4312 connor4312 added the verified Verification succeeded label Mar 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@digitarald @bpasero @Tyriar @connor4312 @JacksonKearl and others