-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit editorOpenWith living on its own #116272
Labels
Comments
bpasero
added
custom-editors
Custom editor API (webview based editors)
debt
Code quality issues
labels
Feb 10, 2021
This is now outdated and please see the proposal in #100281. Feel free to close. |
Closing in favor of #100281 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
I feel the
editorOpenWith.ts
thing needs to go away and move to respective services. It seems wrong to me that you pass in an editor group to operate on instead of having this exposed from theIEditorGroupService
. Here is my thinking:IEditorGroup
(e.g.openEditorWith
)IEditorGroupService.getGroup().openEditorWith(...)
As for the remaining pieces of
editorOpenWith.ts
we can simply move them intosrc/vs/workbench/common/editor.ts
at the end into a new folded region.The text was updated successfully, but these errors were encountered: