Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit editorOpenWith living on its own #116272

Closed
bpasero opened this issue Feb 10, 2021 · 2 comments
Closed

Revisit editorOpenWith living on its own #116272

bpasero opened this issue Feb 10, 2021 · 2 comments
Assignees
Labels
custom-editors Custom editor API (webview based editors) debt Code quality issues

Comments

@bpasero
Copy link
Member

bpasero commented Feb 10, 2021

I feel the editorOpenWith.ts thing needs to go away and move to respective services. It seems wrong to me that you pass in an editor group to operate on instead of having this exposed from the IEditorGroupService. Here is my thinking:

As for the remaining pieces of editorOpenWith.ts we can simply move them into src/vs/workbench/common/editor.ts at the end into a new folded region.

@bpasero
Copy link
Member Author

bpasero commented Feb 12, 2021

This is now outdated and please see the proposal in #100281. Feel free to close.

@lramos15
Copy link
Member

Closing in favor of #100281

@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
custom-editors Custom editor API (webview based editors) debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants