Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enablePersistentSessions for local reconnect #117417

Closed
Tyriar opened this issue Feb 23, 2021 · 2 comments
Closed

Support enablePersistentSessions for local reconnect #117417

Tyriar opened this issue Feb 23, 2021 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Milestone
February 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2021

We missed integrating with the terminal.integrated.enablePersistentSessions setting.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Feb 23, 2021
@Tyriar Tyriar added this to the February 2021 milestone Feb 23, 2021
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Feb 23, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Feb 24, 2021

This did seem to work, but we still kept them alive and never terminated them:

image

Related to #117503

@Tyriar Tyriar mentioned this issue Feb 24, 2021
Closed
Tyriar added a commit that referenced this issue Feb 24, 2021
@Tyriar
Shutdown terminal immediately on last listener remove
4e467af 
The event still isn't being triggered

Part of #117417
Tyriar added a commit that referenced this issue Feb 24, 2021
@Tyriar
Inform pty host of detaches
0d0cb2a 
Fixes #117417
@Tyriar Tyriar closed this as completed in 3139dc7 Feb 24, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Feb 24, 2021

This didn't actually get done completely, shouldPersistTerminal is always true for local terminals

@Tyriar Tyriar reopened this Feb 24, 2021
@Tyriar Tyriar closed this as completed in 8042e9b Feb 24, 2021
@meganrogge meganrogge added the verified Verification succeeded label Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge and others